synced/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-14 10:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix flaky system test (#31822)

Browse Source 
The "Homepage allows users to pick their homepage" system test was flaky
because it was assuming that waiting 5 seconds was enough for the
request to save the user's preferences to complete. This may be true in
development where we have powerful development machines. In production,
Capybara's default wait time is actually 10 seconds so we should respect
that.
This commit is contained in:
Alan Guo Xiang Tan
2025-03-14 16:10:48 +08:00
committed by GitHub
parent dd015af0b8
commit 32e8099258
1 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spec/system/homepage_spec.rb
View File

@ -6,6 +6,7 @@ describe "Homepage", type: :system do
fab!(:topics) { Fabricate.times(5, :post).map(&:topic) }
let(:discovery) { PageObjects::Pages::Discovery.new }
fab!(:theme)
let(:user_preferences_interface_page) { PageObjects::Pages::UserPreferencesInterface.new }
before do
# A workaround to avoid the global notice from interfering with the tests
@ -25,15 +26,13 @@ describe "Homepage", type: :system do
expect(page).to have_css(".navigation-container .latest.active", text: "Latest")
visit "u/#{user.username}/preferences/interface"
user_preferences_interface_page.visit(user)
homepage_picker = PageObjects::Components::SelectKit.new("#home-selector")
homepage_picker.expand
homepage_picker.select_row_by_name("Hot")
page.find(".btn-primary.save-changes").click
# Wait for the save to complete
find(".btn-primary.save-changes:not([disabled])", wait: 5)
user_preferences_interface_page.save_changes
visit "/"
@ -80,35 +79,27 @@ describe "Homepage", type: :system do
visit ""
expect(page).to have_css(".new-home", text: "Hi friends!")
visit "/u/#{user.username}/preferences/interface"
user_preferences_interface_page.visit(user)
homepage_picker = PageObjects::Components::SelectKit.new("#home-selector")
homepage_picker.expand
# user overrides theme custom homepage
homepage_picker.select_row_by_name("Hot")
page.find(".save-changes").click
user_preferences_interface_page.save_changes
expect(page).to have_content(I18n.t("js.saved"))
expect(user.user_option.homepage_id).to eq(UserOption::HOMEPAGES.key("hot"))
click_logo
expect(page).to have_css(".navigation-container .hot.active", text: "Hot")
visit "/u/#{user.username}/preferences/interface"
user_preferences_interface_page.visit(user)
homepage_picker = PageObjects::Components::SelectKit.new("#home-selector")
homepage_picker.expand
# user selects theme custom homepage again
homepage_picker.select_row_by_name("(default)")
page.find(".btn-primary.save-changes").click
# Wait for the save to complete
find(".btn-primary.save-changes:not([disabled])", wait: 5)
try_until_success(timeout: 5) do
expect(user.reload.user_option.homepage_id).to_not eq(UserOption::HOMEPAGES.key("hot"))
end
user_preferences_interface_page.save_changes
click_logo