DEV: Drop unused uppy-upload mixin (#31797)

All consumers have now been updated to use `lib/uppy/uppy-upload`
directly

app/assets/javascripts/discourse/app/lib/uppy-checksum-plugin.js

@@ -1,7 +1,7 @@
 import { Promise } from "rsvp";
 import { bind } from "discourse/lib/decorators";
+import { HUGE_FILE_THRESHOLD_BYTES } from "discourse/lib/uppy/uppy-upload";
 import { UploadPreProcessorPlugin } from "discourse/lib/uppy-plugin-base";
-import { HUGE_FILE_THRESHOLD_BYTES } from "discourse/mixins/uppy-upload";
 
 export default class UppyChecksum extends UploadPreProcessorPlugin {
   static pluginId = "uppy-checksum";

app/assets/javascripts/discourse/app/mixins/uppy-upload.js

@@ -1,138 +0,0 @@
-import { alias, or } from "@ember/object/computed";
-import { readOnly } from "@ember/object/lib/computed/computed_macros";
-import Mixin from "@ember/object/mixin";
-import { getOwner } from "@ember/owner";
-import deprecated from "discourse/lib/deprecated";
-import { deepMerge } from "discourse/lib/object";
-import UppyUpload from "discourse/lib/uppy/uppy-upload";
-
-export { HUGE_FILE_THRESHOLD_BYTES } from "discourse/lib/uppy/uppy-upload";
-
-/**
- * @deprecated
- *
- * This mixin exists only for backwards-compatibility.
- *
- * New implementations should use `lib/uppy/uppy-upload` directly.
- */
-export default Mixin.create({
-  uppyUpload: null,
-
-  _uppyInstance: alias("uppyUpload.uppyWrapper.uppyInstance"),
-  uploadProgress: readOnly("uppyUpload.uploadProgress"),
-  inProgressUploads: readOnly("uppyUpload.inProgressUploads"),
-  filesAwaitingUpload: readOnly("uppyUpload.filesAwaitingUpload"),
-  cancellable: readOnly("uppyUpload.cancellable"),
-  uploadingOrProcessing: or("uppyUpload.uploading", "uppyUpload.processing"),
-  fileInputEl: alias("uppyUpload._fileInputEl"),
-  allowMultipleFiles: readOnly("uppyUpload.allowMultipleFiles"),
-
-  _addFiles: readOnly("uppyUpload.addFiles"),
-  _startUpload: readOnly("uppyUpload.startUpload"),
-
-  // Some places are two-way-binding these properties into parent components
-  // so we can't use computed properties as aliases.
-  // Instead, we have simple properties, with observers that update them when the underlying properties change.
-  uploading: false,
-  processing: false,
-
-  init() {
-    deprecated(
-      "The UppyUploadMixin is deprecated. See discourse/lib/uppy/uppy-upload.js for the new implementation.",
-      {
-        id: "discourse.uppy-upload-mixin",
-      }
-    );
-    this.uppyUpload = new UppyUpload(getOwner(this), configShim(this));
-
-    this.addObserver("uppyUpload.uploading", () =>
-      this.set("uploading", this.uppyUpload.uploading)
-    );
-    this.addObserver("uppyUpload.processing", () =>
-      this.set("processing", this.uppyUpload.processing)
-    );
-
-    this._super();
-  },
-
-  didInsertElement() {
-    if (this.autoFindInput ?? true) {
-      this._fileInputEl = this.element.querySelector(
-        this.fileInputSelector || ".hidden-upload-field"
-      );
-    } else if (!this._fileInputEl) {
-      return;
-    }
-    this.uppyUpload.setup(this._fileInputEl);
-    this._super();
-  },
-
-  willDestroyElement() {
-    this.uppyUpload.teardown();
-    this._super();
-  },
-});
-
-/**
- * Given a component which was written for the old mixin interface,
- * this function will generate a config object which is compatible
- * with the new `lib/uppy/uppy-upload` class.
- */
-function configShim(component) {
-  return {
-    get autoStartUploads() {
-      return component.autoStartUploads ?? true;
-    },
-    get id() {
-      return component.id;
-    },
-    get type() {
-      return component.type;
-    },
-    get uploadRootPath() {
-      return component.uploadRootPath || "/uploads";
-    },
-    get uploadDone() {
-      return component.uploadDone.bind(component);
-    },
-    get validateUploadedFilesOptions() {
-      return component.validateUploadedFilesOptions?.() || {};
-    },
-    get additionalParams() {
-      return deepMerge({}, component.additionalParams, component.data);
-    },
-    get maxFiles() {
-      return component.maxFiles;
-    },
-    get uploadDropTargetOptions() {
-      return (
-        component._uploadDropTargetOptions?.() || { target: component.element }
-      );
-    },
-    get preventDirectS3Uploads() {
-      return component.preventDirectS3Uploads ?? false;
-    },
-    get useChunkedUploads() {
-      return component.useChunkedUploads ?? false;
-    },
-    get useMultipartUploadsIfAvailable() {
-      return component.useMultipartUploadsIfAvailable ?? false;
-    },
-    get uploadError() {
-      return component._handleUploadError?.bind(component);
-    },
-    get uppyReady() {
-      return component._uppyReady?.bind(component);
-    },
-    onProgressUploadsChanged() {
-      component.notifyPropertyChange("inProgressUploads"); // because TrackedArray isn't perfectly compatible with legacy computed properties
-      return component.onProgressUploadsChanged?.call(component, ...arguments);
-    },
-    get uploadUrl() {
-      return component.uploadUrl;
-    },
-    get perFileData() {
-      return component._perFileData?.bind(component);
-    },
-  };
-}