synced/infisical
1
0
Fork 0
mirror of https://github.com/Infisical/infisical.git synced 2025-03-31 22:09:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3120 from Infisical/is-pending-fixes

Browse Source 
Improvement: Use isPending Over isLoading
This commit is contained in:
Scott Wilson
2025-02-14 09:10:05 -08:00
committed by GitHub
parent 2bfc1caec5 e2e7004583
commit 5802638fc4
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/components/secret-syncs/SecretSyncSelect.tsx
View File

@ -10,9 +10,9 @@ type Props = {
};
export const SecretSyncSelect = ({ onSelect }: Props) => {
const { isLoading, data: secretSyncOptions } = useSecretSyncOptions();
const { isPending, data: secretSyncOptions } = useSecretSyncOptions();
if (isLoading) {
if (isPending) {
return (
<div className="flex h-full flex-col items-center justify-center py-2.5">
<Spinner size="lg" className="text-mineshaft-500" />

4
frontend/src/components/secret-syncs/forms/SecretSyncConnectionField.tsx
View File

@ -23,7 +23,7 @@ export const SecretSyncConnectionField = ({ onChange: callback }: Props) => {
const destination = watch("destination");
const app = SECRET_SYNC_CONNECTION_MAP[destination];
const { data: availableConnections, isLoading } = useListAvailableAppConnections(app);
const { data: availableConnections, isPending } = useListAvailableAppConnections(app);
const connectionName = APP_CONNECTION_MAP[app].name;
@ -54,7 +54,7 @@ export const SecretSyncConnectionField = ({ onChange: callback }: Props) => {
onChange(newValue);
if (callback) callback();
}}
isLoading={isLoading}
isLoading={isPending}
options={availableConnections}
placeholder="Select connection..."
getOptionLabel={(option) => option.name}

4
frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionList.tsx
View File

@ -11,9 +11,9 @@ type Props = {
};
export const AppConnectionsSelect = ({ onSelect }: Props) => {
const { isLoading, data: appConnectionOptions } = useAppConnectionOptions();
const { isPending, data: appConnectionOptions } = useAppConnectionOptions();
if (isLoading) {
if (isPending) {
return (
<div className="flex h-full flex-col items-center justify-center py-2.5">
<Spinner size="lg" className="text-mineshaft-500" />

6
frontend/src/pages/organization/AppConnections/AppConnectionsPage/components/AppConnectionsTable.tsx
View File

@ -51,7 +51,7 @@ type AppConnectionFilters = {
};
export const AppConnectionsTable = () => {
const { isLoading, data: appConnections = [] } = useListAppConnections();
const { isPending, data: appConnections = [] } = useListAppConnections();
const { popUp, handlePopUpOpen, handlePopUpToggle } = usePopUp([
"deleteConnection",
@ -262,7 +262,7 @@ export const AppConnectionsTable = () => {
</Tr>
</THead>
<TBody>
{isLoading && (
{isPending && (
<TableSkeleton innerKey="app-connections-table" columns={4} key="app-connections" />
)}
{filteredAppConnections.slice(offset, perPage * page).map((connection) => (
@ -285,7 +285,7 @@ export const AppConnectionsTable = () => {
onChangePerPage={setPerPage}
/>
)}
{!isLoading && !filteredAppConnections?.length && (
{!isPending && !filteredAppConnections?.length && (
<EmptyState
title={
appConnections.length