Resolve review comments

This commit is contained in:
Joel Biddle
2023-10-04 04:50:16 +00:00
parent 390c2cc4d9
commit 726f38c15f
2 changed files with 10 additions and 15 deletions

View File

@ -40,9 +40,7 @@ jobs:
load: true
context: backend
tags: |
infisical/backend:${{ steps.extract_version.outputs.version }}
labels: |
version=${{ steps.extract_version.outputs.version }}
infisical/backend:test
- name: ⏻ Spawn backend container and dependencies
run: |
docker compose -f .github/resources/docker-compose.be-test.yml up --wait --quiet-pull
@ -63,8 +61,6 @@ jobs:
infisical/backend:${{ steps.commit.outputs.short }}
infisical/backend:${{ steps.extract_version.outputs.version }}
platforms: linux/amd64,linux/arm64
labels: |
version=${{ steps.extract_version.outputs.version }}
frontend-image:
name: Build frontend image
@ -95,12 +91,10 @@ jobs:
project: 64mmf0n610
context: frontend
tags: |
infisical/frontend:${{ steps.extract_version.outputs.version }}
infisical/frontend:test
build-args: |
POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }}
NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }}
labels: |
version=${{ steps.extract_version.outputs.version }}
- name: ⏻ Spawn frontend container
run: |
docker run -d --rm --name infisical-frontend-test infisical/frontend:test
@ -123,6 +117,4 @@ jobs:
platforms: linux/amd64,linux/arm64
build-args: |
POSTHOG_API_KEY=${{ secrets.PUBLIC_POSTHOG_API_KEY }}
NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }}
labels: |
version=${{ steps.extract_version.outputs.version }}
NEXT_INFISICAL_PLATFORM_VERSION=${{ steps.extract_version.outputs.version }}

View File

@ -123,6 +123,7 @@ export const AppLayout = ({ children }: LayoutProps) => {
const createWs = useCreateWorkspace();
const uploadWsKey = useUploadWsKey();
const addWsUser = useAddUserToWs();
const infisicalPlatformVersion = process.env.NEXT_PUBLIC_INFISICAL_PLATFORM_VERSION;
const { popUp, handlePopUpOpen, handlePopUpClose, handlePopUpToggle } = usePopUp([
"addNewWs",
@ -697,10 +698,12 @@ export const AppLayout = ({ children }: LayoutProps) => {
</div>
</button>
)}
<div className="mb-2 w-full pl-5 duration-200 hover:text-mineshaft-200">
<FontAwesomeIcon icon={faInfo} className="mr-4 px-[0.1rem]" />
Platform Version: {process.env.NEXT_PUBLIC_INFISICAL_PLATFORM_VERSION || "N/A"}
</div>
{infisicalPlatformVersion && (
<div className="mb-2 w-full pl-5 duration-200 hover:text-mineshaft-200">
<FontAwesomeIcon icon={faInfo} className="mr-4 px-[0.1rem]" />
Platform Version: {infisicalPlatformVersion}
</div>
)}
</div>
</nav>
</aside>