synced/infisical
1
0
Fork 0
mirror of https://github.com/Infisical/infisical.git synced 2025-03-25 14:05:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

improvement: address feedback

Browse Source
This commit is contained in:
Scott Wilson
2024-12-02 09:35:03 -08:00
parent ae51fbb8f2
commit afa2f383c5
2 changed files with 8 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/ApprovalPolicyList.tsx
View File

@ -256,9 +256,7 @@ export const ApprovalPolicyList = ({ workspaceId }: IProps) => {
{!!currentWorkspace &&
filteredPolicies?.map((policy) => (
<ApprovalPolicyRow
// projectSlug={currentWorkspace.slug}
policy={policy}
// workspaceId={workspaceId}
key={policy.id}
members={members}
groups={groups}

29
frontend/src/views/SecretApprovalPage/components/ApprovalPolicyList/components/ApprovalPolicyRow.tsx
View File

@ -41,8 +41,6 @@ type Props = {
policy: IPolicy;
members?: TWorkspaceUser[];
groups?: TGroupMembership[];
// projectSlug: string;
// workspaceId: string;
onEdit: () => void;
onDelete: () => void;
};
@ -51,26 +49,9 @@ export const ApprovalPolicyRow = ({
policy,
members = [],
groups = [],
// projectSlug,
// workspaceId,
onEdit,
onDelete
}: Props) => {
// TODO(scott): add back to enable editing from modal? edit modal for policy is fine for now
// const [selectedApprovers, setSelectedApprovers] = useState<Approver[]>(
// policy.approvers?.filter((approver) => approver.type === ApproverType.User) || []
// );
// const [selectedGroupApprovers, setSelectedGroupApprovers] = useState<Approver[]>(
// policy.approvers?.filter((approver) => approver.type === ApproverType.Group) || []
// );
// const { mutate: updateAccessApprovalPolicy, isLoading: isAccessApprovalPolicyLoading } =
// useUpdateAccessApprovalPolicy();
// const { mutate: updateSecretApprovalPolicy, isLoading: isSecretApprovalPolicyLoading } =
// useUpdateSecretApprovalPolicy();
// const isLoading = isAccessApprovalPolicyLoading || isSecretApprovalPolicyLoading;
//
// const { permission } = useProjectPermission();
const labels = useMemo(() => {
const usersInPolicy = policy.approvers
?.filter((approver) => approver.type === ApproverType.User)
@ -106,12 +87,18 @@ export const ApprovalPolicyRow = ({
<Td>{policy.environment.slug}</Td>
<Td>{policy.secretPath || "*"}</Td>
<Td className="max-w-0">
<Tooltip content={labels.members ?? "No users are assigned as approvers for this policy"}>
<Tooltip
side="left"
content={labels.members ?? "No users are assigned as approvers for this policy"}
>
<p className="truncate">{labels.members ?? "-"}</p>
</Tooltip>
</Td>
<Td className="max-w-0">
<Tooltip content={labels.groups ?? "No groups are assigned as approvers for this policy"}>
<Tooltip
side="left"
content={labels.groups ?? "No groups are assigned as approvers for this policy"}
>
<p className="truncate">{labels.groups ?? "-"}</p>
</Tooltip>
</Td>