5908 Commits

Author SHA1 Message Date
973d7d609a fix: allow searching css with dash e.g. flex-direction (#4996)
In advanced panel in both search in put and add property autocomplete
right now if you type dash it won't find anything with dash

## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-13 19:31:02 +01:00
af653fa002 refactor: hyphenate keyword values (#4987)
Regenerated keyword values data with hyphenated properties. Since the
new object is strictly typed we can use it directly without
styleConfigByName utility which I removed.
2025-03-13 22:44:57 +07:00
a273abadb4 fix: navigate to home page when undo page creation (#4995)
Fixes https://github.com/webstudio-is/webstudio/issues/4993
2025-03-13 22:32:59 +07:00
d6f37ef359 fix: load resources when switch pages (#4994)
Fixes https://github.com/webstudio-is/webstudio/issues/4992
2025-03-13 22:15:19 +07:00
9442afcb11 fix: Long redirects urls and paths don't shorten in the UI (#4944) (#4988)
## Description

fix issue #4944 
long redirect urls don't shorten, they extend across Project seetings
container and parts of it disappears which make UI looks broken.

i added a word-break to the links, set a width for old link and
max-width for the new-path link.

![Screen Shot 2025-03-12 at 12 02 52
PM](https://github.com/user-attachments/assets/72743a23-9f8b-4df3-abca-65524db8df91)
  

## Steps for reproduction

1. click on Menu button
2. click on "Project settings" Menu item
3. Click on the Redirects on the sidebar
4. Input old-path and new-path or URL
5. Click Add

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [x] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [x] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file

---------

Co-authored-by: Oleg Isonen <oleg008@gmail.com>
2025-03-13 15:41:56 +01:00
62b0418476 experimental: Use css editor in keyframes (#4952)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-13 15:20:14 +01:00
dd08852d43 build: upgrade typescript (#4991)
Upgraded to 5.8 and bumped all type definitions.
Enabled erasable syntax only flag and got rid from one case in
expression editor.
2025-03-13 11:21:00 +07:00
8b526dc7e9 refactor: store webhook form action as resource (#4983)
Ref https://github.com/webstudio-is/webstudio/issues/4093

Here's refactoring to unlock resource UI in webhook form

Need to test in builder and on published site

1. Create webhook form in main and try to update it on this branch. So
legacy text prop should automatically migrate to resource.

2. New webhook form should create resource when type anything in action
prop
2025-03-13 11:02:44 +07:00
fcb4e25a9e feat: show unresolved inherited values in style panel (#4990)
Per user request we will not show computed value when inherited from
ancestor.
Chrome devtools seem to show unresolved values in "inherited" section.

<img width="252" alt="image"
src="https://github.com/user-attachments/assets/b7f22ec5-e2ea-47aa-9bad-80622d0aa5f9"
/>
2025-03-13 00:20:46 +07:00
016979166b experimental: Fix various issues with animation subtree changes (#4986)
## Description

- Use mutation observer on AnimateText to check subtree changes.
- Add last resort animation restart - unpin/pin animation.


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-12 18:16:32 +05:00
8c72bad82d fix: format publishing tooltip properly (#4985)
<img width="337" alt="Screenshot 2025-03-12 at 11 29 27"
src="https://github.com/user-attachments/assets/ed8bbea2-ae1c-4678-ad7a-d5e99ce9f368"
/>
2025-03-12 14:20:09 +07:00
81c5d6e989 experimental: Animations Prefer reduced motion and noscript support (#4984)
## Description

See corresponding linked PR

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-11 20:47:51 +05:00
58a0da8855 refactor: hyphenate all sections (#4981)
Migrated to hyphenated properties all left sections

- filter
- list item
- transforms
- typography
2025-03-11 20:17:18 +07:00
935983b543 build: upgrade checks (#4982)
- vitest
- testing-library (got much lighter)
- eslint and plugins (@types/eslint__js no longer necessary)
- storybook
- esbuild
2025-03-11 15:22:57 +07:00
ca4b0f89bc experimental: Animation publishing (#4976)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-11 11:19:01 +05:00
051c1ba226 refactor: hyphenate style engine (#4977)
Migrated style object model to hyphenated css properties. A lot of
conversions no longer necessary.
2025-03-11 01:01:37 +07:00
9133c72961 feat: Improve search and new property autocompletion in advanced style panel (#4979)
## Description

1. Allow matching "gr te co" -> "grid-template-columns" when searching
2. Same thing when adding a new property/value

## Steps for reproduction

1. click button
3. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-10 18:03:35 +01:00
16258bb9b5 refactor: bump remix (#4972)
Upgraded legacy remix. The new version got vite 6 support so we could
upgrade it later.
2025-03-10 16:41:01 +07:00
b7790433fe fix: Chrome dev mode scrolls into center aligned text editor (#4975)
## Description

Fixes an issue in DEV MODE where, if text is center-aligned inside
Flex/Grid,
the code below causes Chrome to scroll the editable text block to the
center of the view.


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-10 13:44:02 +05:00
70d51221b3 experimental: Text Animation storybook (#4938)
# Description

This PR introduces prototypes for a set of versatile animation
components:
• AnimateProxy: A wrapper component supporting staggered animations and
integrations with third-party animation engines.
• AnimateTextProgress: Demonstrates per-character staggered text
animations.

👉 [View Storybook
Preview](https://6382151c8b47d4399fb9fc69-uyomckzwfj.chromatic.com/iframe.html?args=&globals=&id=sdk-components-animation-animate-proxy--in-out&viewMode=story)

Features
	•	Added Storybook examples showcasing text animation capabilities.
• Supports custom CSS properties within keyframes for enhanced animation
flexibility.

Upcoming PRs

Future PRs will introduce more specialized animation components
utilizing the AnimateProxy:
```jsx
// Example usage of AnimateText
<AnimateProxy>
  {($progress, getStylesAt) => (
    <AnimateTextProgress
      $progress={$progress}
      getStylesAt={getStylesAt}
      charWindow={50}
      easing="easeInQuart"
    >
      {children}
    </AnimateTextProgress>
  )}
</AnimateProxy>

// Example usage of AnimateStager
<AnimateProxy>
  {($progress, getStylesAt) => (
    <Stager
      $progress={$progress}
      getStylesAt={getStylesAt}
      // Additional props...
    />
  )}
</AnimateProxy>

// Example usage of AnimateLottie
<AnimateProxy>
  {($progress, getStylesAt) => (
    <Lottie
      $progress={$progress}
      getStylesAt={getStylesAt}
      // Additional props...
    />
  )}
</AnimateProxy>
```
See corresponding PR: (link to be added)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-10 12:44:15 +05:00
68cce117e6 refactor: hyphenate space and position sections (#4973)
Slightly refactored both space and position sections. Moved property
maps from scrub and keyboard to dedicated sections.

Also fixed keyboard highlighting in space and inset controls.
2025-03-09 16:57:39 +07:00
3c8ac56c39 refactor: migrate properties data to hyphen case (#4970)
properties data are now more type safe and can accept any CssProperty
name though in case of custom properties (--string) will return
undefined.

This also removes a lot of `keyof typeof properties` castings.
2025-03-08 20:26:40 +07:00
fbe9eed7ca refactor: avoid rendering button inside button (#4968)
Color thumb should be a button only inside of color picker when it is
clickable. In case of repeated style it is just a visual indicator.

This fixes huge react warnings about button rendered inside of another
button.
2025-03-08 19:05:21 +07:00
af98a41edf fix: update display from none (#4969)
Fixes https://github.com/webstudio-is/webstudio/issues/4963

Looks like accidentally wrong method was used.
2025-03-08 12:23:47 +01:00
7a41a1e733 fix: render empty page when xml is empty (#4966) 2025-03-08 01:21:12 +07:00
b6437fe0df fix: handle empty xml (#4965)
XML body did not have any children and the logic had runtime error.
2025-03-07 23:50:20 +07:00
2a21fc7eeb fix: Optionally memorize min height in style panel advanced css editor (#4962)
[Discussion](https://discord.com/channels/955905230107738152/1347444065402224691)

## Description

When advanced css editor is used in the style panel, we are avoiding
jumps by preserving the scroll height, but in advanced mode when there
is no parent scroll - we don't need that, so we can avoid blank space
scrollbar.

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-07 12:16:36 +01:00
6a453b94dc refactor: migrate border and outline to hyphenated properties (#4960)
Migrated two more sections and made ComputedStyleDecl['property'] more
strict instead of just a string, now can get rid from `as StyleProperty`
casting all over the codebase.
2025-03-07 17:16:16 +07:00
dc9eb34289 refactor: bump react-router (#4961)
Upgrade react-router to 7.3

Removed unused dependencies in this version
https://github.com/remix-run/react-router/pull/13134
2025-03-07 16:47:59 +07:00
6d00184f93 refactor: accept hyphenated property in css value parser (#4959)
No longer need to use camel cased property in parseCssValue
2025-03-07 02:03:22 +07:00
84b4f67fab refactor: migrate repeated styles to hyphenated properties (#4958)
These all are now using hyphenated properties instead of camel case

- background
- text-shadow
- box-shadow
- backdrop-filter
2025-03-07 00:47:42 +07:00
ab65d8e2a3 experimental: support linear() easing (#4957)
Now it is parsed as "unparsed" :)
2025-03-06 22:31:14 +07:00
4a348ed9c6 fix: Refix bigger clickable surface for local style source (#4956)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-06 12:32:31 +01:00
e306b4633f fix: Fix token state selector (#4955)
## Description

Select the state, see it stays selected

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-06 11:36:33 +01:00
e9ca01534e fix: Fixes saving binding when closing popover by click outside (#4941)
## Description

<img width="518" alt="image"
src="https://github.com/user-attachments/assets/9326dd07-2244-4f57-ae93-a9ab3bf0f38d"
/>


When you are creating a binding from inside a variable dialog and having
popover opened from a popover, when you click outside, binding won't be
saved

## Steps for reproduction

1. create resource variable
2. close
3. edit that variabel
4. bind url
5. click outside of both popovers
6. see changes were saved

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-06 10:53:07 +01:00
88cf25315b feat: use 24px item height to fit more in the navigator (#4933)
## Description

When we switched to 24px height of inputs, I forgot to update navigator
items. Currently complex components are hard to navigate because they
don't fit in the panel and you are always scrolling too much

<img width="284" alt="image"
src="https://github.com/user-attachments/assets/86800211-7290-433d-8c73-081f3fdcbb3a"
/>

<img width="283" alt="image"
src="https://github.com/user-attachments/assets/971428cf-1117-4bbf-b0e0-548e6c5bd8fa"
/>


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-06 01:41:34 +01:00
d28428e2bf feat: Add mdn link to all properties in advanced style panel (#4951)
## Description

The little link icon button

<img width="276" alt="image"
src="https://github.com/user-attachments/assets/5553a892-a3b7-46ae-b00a-c56c1a7833cf"
/>


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-05 22:51:12 +01:00
d5edc483ea fix: When deleting property during search in advanced panel - remove it from results (#4950)
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-05 21:47:04 +01:00
02bcc55299 feat: Delete declaration and delete all declarations in advanced style panel context menu (#4948)
## Description

1. added additional way to delete a declaration in addition to cmd+click
2. delete all declarations

## Steps for reproduction

1. click button
3. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-05 21:12:18 +01:00
5ba9dc38a8 experimental: Reusable css editor (#4945)
## Description

For using in animations UI we need a reusable css editor.

## Steps for reproduction

This PR should not have changed how advanced section works at all. This
is pure refactoring.

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-05 16:52:21 +01:00
a344b34cf7 refactor: generate only asset name for published sites (#4947)
We don't really need anything from asset object on published sites
except the name to resolve the file.

Here got rid from Asset objects for favicon, fonts and backgrounds. This
should reduce client bundle where a lot of assets are used.
2025-03-05 20:54:34 +07:00
0f3a308ee4 refactor: migrate layout and size to hyphenated properties (#4946)
First style sections migrated from camel case to hyphenated style
properties.
2025-03-05 20:40:05 +07:00
238e300f6d refactor: simplify xml generation (#4942)
- got rid of svg hacks, suffix seems work well
- filtered data instead of generating empty components
- fixed sitemap in features fixture
2025-03-05 12:44:38 +07:00
85f83b6e48 refactor: accept both camel and hyphen properties everywhere (#4943)
Here improved all reusable logic to accept both camel and hyphen cases
in properties. This will ease migration to hyphen style.
2025-03-05 10:39:02 +07:00
bdf4463098 fix: set proper default value in radix with content block (#4937)
Some checks failed
Chromatic / chromatic (push) Has been cancelled
Main workflow / checks (development) (push) Has been cancelled
Main workflow / checks (empty) (push) Has been cancelled
Main workflow / check-size (push) Has been cancelled
Vercel Deploy Staging / deployment (development, ${{ endsWith(github.ref_name, '.staging') }}) (push) Has been cancelled
Vercel Deploy Staging / deployment (staging, ${{ endsWith(github.ref_name, '.staging') }}) (push) Has been cancelled
Vercel Deploy Staging / fixtures-test (push) Has been cancelled
Vercel Deploy Staging / delete-github-deployments (push) Has been cancelled
Visual Regression Tests / lost-pixel (push) Has been cancelled
User reported in discord.

Radix components like accordion does not open first item by default when
use with content block. The reason was in our default detection.

We used indexes within ancestor and when put item inside of content
block template it gets 0 but not rendered.

Here improved the logic to reset index when render inside of block
template.

<img width="837" alt="Screenshot 2025-03-01 at 21 14 09"
src="https://github.com/user-attachments/assets/788df39a-b7c5-466b-a80e-09cc40de9e3f"
/>
2025-03-04 18:26:29 +07:00
0889342c33 refactor: switch to hyphenated preset styles (#4930)
Replaced camel case with kebab in all presets
2025-03-04 17:26:32 +07:00
75b82d69a2 feat: Additional way to reset in spacing (#4924)
Some checks failed
Chromatic / chromatic (push) Has been cancelled
Main workflow / checks (development) (push) Has been cancelled
Main workflow / checks (empty) (push) Has been cancelled
Main workflow / check-size (push) Has been cancelled
Migrate / migrate (push) Has been cancelled
Migrate / db-tests (push) Has been cancelled
Migrate / pending (push) Has been cancelled
Vercel Deploy Staging / deployment (development, ${{ endsWith(github.ref_name, '.staging') }}) (push) Has been cancelled
Vercel Deploy Staging / deployment (staging, ${{ endsWith(github.ref_name, '.staging') }}) (push) Has been cancelled
Vercel Deploy Staging / fixtures-test (push) Has been cancelled
Vercel Deploy Staging / delete-github-deployments (push) Has been cancelled
Visual Regression Tests / lost-pixel (push) Has been cancelled
## Description

closes https://github.com/webstudio-is/webstudio/issues/4844

As a user when I don't know about option+click shorthand, and try to
reset spacing, only other way is to wait for the tooltip to come. If you
click, like you do on other labels - input will come but no way to
reset.

Solution: show a label next to the input.

## Steps for reproduction

1. click on any spacing value
2. see label next to input
3. test usual label functionality

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-02 20:17:44 +01:00
ddc425cd40 fix: navigate hash urls natively (#4929)
Some checks are pending
Chromatic / chromatic (push) Waiting to run
Main workflow / checks (development) (push) Waiting to run
Main workflow / checks (empty) (push) Waiting to run
Main workflow / check-size (push) Waiting to run
Migrate / migrate (push) Waiting to run
Migrate / db-tests (push) Blocked by required conditions
Migrate / pending (push) Blocked by required conditions
Vercel Deploy Staging / deployment (development, ${{ endsWith(github.ref_name, '.staging') }}) (push) Waiting to run
Vercel Deploy Staging / deployment (staging, ${{ endsWith(github.ref_name, '.staging') }}) (push) Waiting to run
Vercel Deploy Staging / fixtures-test (push) Blocked by required conditions
Vercel Deploy Staging / delete-github-deployments (push) Blocked by required conditions
Visual Regression Tests / lost-pixel (push) Waiting to run
Fixes https://github.com/webstudio-is/webstudio/issues/4830

Remix incorrectly navigates hashes and clear search params. Here fixed
this by using native `<a>` and tweaked the logic in builder.

Test navigating hashes (when search params are present) in builder and
on published site.
2025-03-02 11:05:37 +07:00
11c6521988 fix: Fixes 2 bugs in advanced panel (#4935)
Some checks are pending
Chromatic / chromatic (push) Waiting to run
Main workflow / checks (development) (push) Waiting to run
Main workflow / checks (empty) (push) Waiting to run
Main workflow / check-size (push) Waiting to run
Migrate / migrate (push) Waiting to run
Migrate / db-tests (push) Blocked by required conditions
Migrate / pending (push) Blocked by required conditions
Vercel Deploy Staging / deployment (development, ${{ endsWith(github.ref_name, '.staging') }}) (push) Waiting to run
Vercel Deploy Staging / deployment (staging, ${{ endsWith(github.ref_name, '.staging') }}) (push) Waiting to run
Vercel Deploy Staging / fixtures-test (push) Blocked by required conditions
Vercel Deploy Staging / delete-github-deployments (push) Blocked by required conditions
Visual Regression Tests / lost-pixel (push) Waiting to run
## Description

Use case 1
1. add a property
2. copy all
3. paste into any text editor
4. see that recent one is not copied

Use case 2
1. add 2 properties
2. use backspace to reset the second property
3. focus should be on the first value after deleting the second one
4. use backspace to delete the first property
5. see focus jumped to search

## Steps for reproduction

1. click button
6. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-01 15:50:08 +01:00
36afe0cf93 fix: Strange behaviour on scroll with tooltip content (#4934)
## Description


https://discord.com/channels/955905230107738152/1345038669496586310/1345038669496586310

- [x] This fix introduces other bug
https://p-0f63c6ab-adfe-4052-b065-d87223ef2b03-dot-fix-scroll-tooltip.development.webstudio.is/
start editing text in content block, up arrow, scroll on button is
broken

<img width="290" alt="image"
src="https://github.com/user-attachments/assets/ed2dff1e-ef01-4844-9123-e2212f9853a6"
/>


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2025-03-01 16:21:59 +05:00