synced/coder
1
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2025-07-18 13:35:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(site): fix scroll when having many build options (#10744)

Browse Source
This commit is contained in:
Bruno Quaresma
2023-11-16 19:13:59 -03:00
committed by GitHub
parent 88c1ee6d52
commit ba955f44d0
1 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
View File

@ -37,6 +37,14 @@ export const BuildParametersPopover = ({
disabled?: boolean;
onSubmit: (buildParameters: WorkspaceBuildParameter[]) => void;
}) => {
const { data: parameters } = useQuery({
queryKey: ["workspace", workspace.id, "parameters"],
queryFn: () => getWorkspaceParameters(workspace),
});
const ephemeralParameters = parameters
? parameters.templateVersionRichParameters.filter((p) => p.ephemeral)
: undefined;
return (
<Popover>
<PopoverTrigger>
@ -54,7 +62,8 @@ export const BuildParametersPopover = ({
css={{ ".MuiPaper-root": { width: 304 } }}
>
<BuildParametersPopoverContent
workspace={workspace}
ephemeralParameters={ephemeralParameters}
buildParameters={parameters?.buildParameters}
onSubmit={onSubmit}
/>
</PopoverContent>
@ -63,25 +72,19 @@ export const BuildParametersPopover = ({
};
const BuildParametersPopoverContent = ({
workspace,
onSubmit,
ephemeralParameters,
buildParameters,
}: {
workspace: Workspace;
onSubmit: (buildParameters: WorkspaceBuildParameter[]) => void;
ephemeralParameters?: TemplateVersionParameter[];
buildParameters?: WorkspaceBuildParameter[];
}) => {
const popover = usePopover();
const { data: parameters } = useQuery({
queryKey: ["workspace", workspace.id, "parameters"],
queryFn: () => getWorkspaceParameters(workspace),
enabled: popover.isOpen,
});
const ephemeralParameters = parameters
? parameters.templateVersionRichParameters.filter((p) => p.ephemeral)
: undefined;
return (
<>
{parameters && parameters.buildParameters && ephemeralParameters ? (
{buildParameters && ephemeralParameters ? (
ephemeralParameters.length > 0 ? (
<>
<Box
@ -103,7 +106,7 @@ const BuildParametersPopoverContent = ({
popover.setIsOpen(false);
}}
ephemeralParameters={ephemeralParameters}
buildParameters={parameters.buildParameters}
buildParameters={buildParameters}
/>
</Box>
</>